Add converter for typedef property
#1370
Conversation
hyperupcall
changed the title
Dependencies.mdtypedef property
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Awesome, looks good so far. Glad to see this rule finally getting taken care of! 👏
Tests are failing (ci link) because a lack of coverage on lines 11,15,19,27,31. You'll want to add >=1 test case that covers them.
JoshuaKGoldberg
added
the
status: waiting for author
Huh, sorry about that - I'll send a separate PR to add it in. |
Nice, following up on that too: #1374 |
|
Thank you for your feedback! 😃 I will push the improved coverage and address your replies by this |
|
Good luck on the exams! ❤️ |
This also uses `Set` to improve time complexity of searching to `O(n)` time
This adds full support to `explicit-function-return-type` and `explicit-module-boundary-type`
|
I've implemented the changes, including use of Also, both Thank you for your patience, and let me know if I missed anything or should make any other changes! ^w^ |
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Super, thanks so much @hyperupcall! 🙌
JoshuaKGoldberg
removed
the
status: waiting for author
|
This should be available in [email protected]. |
2 participants
Hoi! ^w^ 👋
PR Checklist
status: accepting prsOverview
The typedef property of TSLint is now considered during the conversion. All config options except
call-signatureandarrow-call-signatureare accounted for. Options unaccounted for are mentioned in thenoticesarray, when applicableThe linked issue and the ESLint typedef docs mentions that explicit-function-return-type and explicit-module-boundary-types should be used when converting
call-signatureandarrow-call-signature. I did that in a separate branch here, but I wasn't 100% confident that my conversion was correct, so I left it out for now. If it is close to what is considered acceptable, maybe I can add it to this PR?I'll also add that I had to install
@swc/coreto get things to run, despite this mentioning its not required - not sure what's up with that. Also the Docs say Node 12 works, but 14 was the minimum LTS that worked for me (Jest threwSyntaxError: Unexpected token '.'when it encountered optional chaining)